scrimba
Code Review of Osher's Learning Journal
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Osher's Learning Journal
AboutCommentsNotes
Code Review of Osher's Learning Journal
Expand for more info
code-review.md
run
preview
console
# Module: No. 6 - Responsive Design
# Project: My Learning Journal by Osher
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met and exceeded all the objectives of this project:
1. 3 pages.
2. Responsive design with relative units, mobile-first, media queries, and viewport meta tag.
3. You added your own style.
4. You rendered multiple posts.
5. You implemented light/dark theme.
6. You used CSS variables.
7. You used flexbox and grid system for layout.


## Suggestions for Improvement:

1. Be conssitent with your file naming.
2. Be consistent with your whitespacing for organization.
3. Break down `index.js` into parts. You could have a `Post` class in a separate file which you could import and use. You could create a separate `aboutMe.html` file rather than redenring the whole HTML page as a function in the same `index.js` file.


## Conclusion:

You clearly put a good amount of work on this project and it shows. Well done. I hope you found my suggestions useful. I wish you the best in your journey. Keep on coding.


Console
/index.html#
-4:44