scrimba
Code Review of Jason's Password Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Jason's Password Generator
AboutCommentsNotes
Code Review of Jason's Password Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Password Generator by Jason
# Code Reviewer: Shant Dashjian


## What You Did Well

1. Well done! You meet all the core objectives of the project.
1. Follow the Figma design.
2. Generate 2 random passwords.
3. Make each 15 characters long. You go beyond this.
2. The user could increase and decrease the length of the passwords generated within a range.
3. The user could add or remove letters, numbers, and special characters.
4. You made good use of regular expressions and the spread operator.


## Suggestions for Improvement

1. Use descriptive names for your variables and functions for better readability.
2. Use booleans for flags, rather than 0 and 1.
3. Use one naming convention for your CSS.


## Conclusion

I think you did very well meeting and exceeding the objectives. I wish you all the best in your journey and I hope you found my suggestions useful. Keep on coding.

Console
/index.html
-19:17