Code Review of Aneeba's Unit Conversion

scrimba

Watch in fullscreen

by Shant Dashjian

About

Comments

Notes

Code Review of Aneeba's Unit Conversion

by Shant Dashjian

Expand for more info

code-review.md

run

preview

console

# Unit Converter by Aneeba
# Module: 3 - Making Websites Interactive
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You mostly met the objectives of this project:
    1. You mostly followed the design spec. See Suggestion No. 1.
    2. It converts the value between metric and imperial systems for length, volume, and mass.
    3. You round the results to 3 decimal places using `.toFixed()`.
2. You tried to stretch the app to show two apps, one for each themes: light and dark.


## Suggestions for Improvement:

1. Link or import the Inter font.
2. Use a collection of elements using `class`, rather than `id`, to make both apps work.


## Conclusion:

You did well meeting the objectives of this project, practicing a good amount of JavaScript concepts. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.

# Unit Converter by Aneeba

# Module: 3 - Making Websites Interactive

# Code Reviewer: Shant Dashjian

## What You Did Well:

1. You mostly met the objectives of this project:

1. You mostly followed the design spec. See Suggestion No. 1.

2. It converts the value between metric and imperial systems for length, volume, and mass.

3. You round the results to 3 decimal places using `.toFixed()`.

2. You tried to stretch the app to show two apps, one for each themes: light and dark.

## Suggestions for Improvement:

1. Link or import the Inter font.

2. Use a collection of elements using `class`, rather than `id`, to make both apps work.

## Conclusion:

You did well meeting the objectives of this project, practicing a good amount of JavaScript

concepts. I hope you found my suggestions useful and I wish you the best in your journey. Keep on

coding.

-19:44