scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Cory's Learning Journal
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Cory's Learning Journal
AboutCommentsNotes
Code Review of Cory's Learning Journal
Expand for more info
code-review.md
run
preview
console
# Module: No. 6 - Responsive Design
# My Learning Journal by Cory
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met all the objectives of this project:
1. 3 pages.
2. Responsive design with relative units, mobile-first, media queries, and viewport meta tag.
2. You used both flexbox and grid for a good responsive layout.
3. You organized your code well, with comments and whitespace.
4. You used semantic HTML.
5. You followed CSS naming conventions.
6. You linked the pages to each other.


## Suggestions for Improvement:
1. Use `nav` tag for the navigation bar, another semnatic HTML for better readability and accessability.
2. Import your Google Font in the CSS so it's in one place, rather than linking it in three different HTML files.


## Conclusion:

I think you submitted a solid solo project here, meeting all the objectives and beyond. I wish you the best in your journey. Keep on coding.


Console
/index.html
-3:36