scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Akshitha's Color Scheme Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Akshitha's Color Scheme Generator
AboutCommentsNotes
Code Review of Akshitha's Color Scheme Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 9 - Working with APIs
# Project: Color Scheme Generator by Akshitha
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
1. Choose seed color with input of type=“color”.
2. Choose color scheme mode with <select> box.
3. Clicking button makes request to the Color API.
4. Display the colors and their hex values.
2. You implmeneted the copying feature.
3. You picked a cool font.
4. You made your app responsive using media queries.


## Suggestions for Improvement:

1. Be consistent with following one naming convention for your CSS ids and classes.
2. Deal with fetching errors using `catch`.
3. Instead of using `alert`, display a simple message in HTML to tell the user that the color hex code got copied. For some reason, using `alert` is giving you an error (check your Netlify app console) and it's messing with the copying.


## Conclusion:

You met and exceeded the objectives. I hope you found my suggestions useful. Keep on coding.
Console
"#F9A2A2"
,
!
Error: Cannot parse given Error object
,
/index.html
-4:44