scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Jon's Unit Converter
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Jon's Unit Converter
AboutCommentsNotes
Code Review of Jon's Unit Converter
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Unit Converter by Jon
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
1. Follow the design spec.
2. Convert to both systems for length, volume, and mass.
3. Round to 3 decimal places.
2. You used an interesting technique using `::before` and `::after` effects to provide equal spacing around elements in the top section.
3. You used array and objects in a smart way to have a DRY code.
4. Your code is well-organized.


## Suggestions for Improvement:

1. Deal with negative numbers.
2. Simplify calculations.
3. Remove the unneeded field in yor objects.


## Conclusion:

You did well meeting the objectives of this project. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.
Console
/index.html
-6:56