Code Review of BiggerDifficulty's Hometown Homepage

scrimba

Watch in fullscreen

by Shant Dashjian

About

Comments

Notes

Code Review of BiggerDifficulty's Hometown Homepage

by Shant Dashjian

Expand for more info

code-review.md

run

preview

console

# Module: No. 2 - Web Dev Basics
# Project: Hometown Homepage by BiggerDifficulty
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You followed the design spec.
2. You met all other objectives of the project: 
    1. CSS classes 
    2. Flexbox 
    3. background-image
    4. Color palette.
3. You used the `:hover` pseudoclass.


## Suggestions for Improvement:

1. Add a `title` to your site for better SEO and UX.
2. Use CSS `var` to reduce unneded repetition and improve maintainability.
3. In regards to the header image, it is expanding while maintaining ratio because that is how `background-size: cover;` behaves. For different behaviors of the `background-size` property, see: https://developer.mozilla.org/en-US/docs/Web/CSS/background-size. 


## Conclusion:

Good job meeting the objectives of this project. I hope you found my suggestions useful. Keep on coding.

# Module: No. 2 - Web Dev Basics

# Project: Hometown Homepage by BiggerDifficulty

# Code Reviewer: Shant Dashjian

## What You Did Well:

1. You followed the design spec.

2. You met all other objectives of the project:

1. CSS classes

2. Flexbox

3. background-image

4. Color palette.

3. You used the `:hover` pseudoclass.

## Suggestions for Improvement:

1. Add a `title` to your site for better SEO and UX.

2. Use CSS `var` to reduce unneded repetition and improve maintainability.

3. In regards to the header image, it is expanding while maintaining ratio because that is how

`background-size: cover;` behaves. For different behaviors of the `background-size` property, see:

https://developer.mozilla.org/en-US/docs/Web/CSS/background-size.

## Conclusion:

-5:53