scrimba
Bootcamp code reviews
πŸ‘©πŸΌβ€πŸ« Review of Solo Project - Learning Journal for Brian
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

πŸ‘©πŸΌβ€πŸ« Review of Solo Project - Learning Journal for Brian
AboutCommentsNotes
πŸ‘©πŸΌβ€πŸ« Review of Solo Project - Learning Journal for Brian
Expand for more info
readme.md
run
preview
console

# Code Review: Learning Journal
### _Code by: Brian ,_
### _Reviewer: Felicity Evans_

## What you did well
- matched design
- mobile first
- cleanly indented
- using HTML5 elemnents for semantic meaning
- revisited code (I think!)

## Questions
Just wanted to get feedback on CSS grid since this was based on a CSS Grid module. Unfortunately i still had to depend on Flexbox since i am more comfortable with Flexbox, so I would appreciate on what i can improve with CSS grid and how can i refactor the Flexbox code to CSS Grid.

## What could be improved?
- Use links to great paths around website
Think in terms of templates
- 3 across in grid not two across
grid-template-columns: repeat(auto-fill, minmax(400px, 1fr)
- Use class styles when taregting specific elements on page
e.g. ul
- think about class names e.g. ".hidden"
- Avoid use of id for styling / can cause problems with specificity
http://css-specificity.smnarnold.com/?level=tag-vs-class
Console
/about-me.html
-12:21