scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Osher's Restaurant Ordering app
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Osher's Restaurant Ordering app
AboutCommentsNotes
Code Review of Osher's Restaurant Ordering app
Expand for more info
code-review.md
run
preview
console
# Module: No. 5 - Essential JS Concepts
# Project: Restaurant Ordering App by Osher
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
1. You followed the design spec.
2. You render the menu options using JavaScript.
3. It adds items to the order, gets the total, completes the order, and gets payment information.
4. Your input fields are required.
2. You accumulate and add multiple instances of the same item to the same line in the order.
3. You also show a total count of items.
4. When user clicks Pay, you add a cool effect of loading and payment confirmation.
5. You used the new concept of optional chaining in the `bindCompleteEvent()` function.


## Suggestions for Improvement:

1. Remove dev console.logs.
2. Make your JavaScript code DRYer and better structured.
3. Provide input type and format validation for credit card number and CVV fields. At minimum those fields shouldn't accept non-numneric characters.


## Conclusion:

You did well meeting the objectives of this project, practicing a good number of JavaScript concepts. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.
Console
/index.html
-13:45