# Code Review: Learning journal
### _Code by: Chris (chrisv#0786)_
### _Reviewer: Felicity Evans_
## What you did well
- Used flexbox
- Used grid minmax
- Semantic elements: nav, section
## Questions
this was a difficult one for me to get right. it's not easy for me to think about which divs need
to be resized. I don't know how to remove the hyperlinks from the homepage (the blog posts all have
hyper links). The Main Post page doesn't seem centered. I still need to add the About me Section.
## What you could improve
- Indentation causing issues...
Index.html
unclosed <a> tag around blog posts
Blog-post
Unclosed <div class="main-post">
About.html
error empty img tag in about.html
- <img src="">
- use placeholder.it https://progressivewebexperience.io
e.g. <img src="http://placehold.it/350x150">
Think: which elemets are the same? ... leads to component based thinking, not content based thinking
missing closing div
CSS
- Use font with <links> provided by Google and not import
- .main-post, padding use % padding or @media query
- grouping according to padding
- media query @media (min-width: 55em) unclear
## Challenge
See if you can complete the about page