scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Syndicate's Unit Converter
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Syndicate's Unit Converter
AboutCommentsNotes
Code Review of Syndicate's Unit Converter
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Unit Converter by Syndicate
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
1. Follow the design spec.
2. Convert to both systems for length, volume, and mass.
3. Round to 3 decimal places.
2. You folowed JS and CSS naming convnetions.
3. You showed good code organization.
4. You used constants when needed, i.e. no magic numbers.


## Suggestions for Improvement:

1. Clean up unneeded comments.
2. Don't Repeat Yourself: Make your function cleaner.
3. Resize input field dynamically based on input.
4. Limit input to non-negative numbers without making the input type=number.
5. Only round numbers with non-zero decimal places.
6. Switch between singular and plural based on value displayed by buiding your HTML in JS.


## Conclusion:

You did well meeting the objectives of this project. It's good that you ask for specific feedback as it shows your focus and desire to grow as a developer. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.
Console
/index.html
-29:10