scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Mark's The Daily Dribble Newsletter
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Mark's The Daily Dribble Newsletter
AboutCommentsNotes
Code Review of Mark's The Daily Dribble Newsletter
Expand for more info
code-review.md
run
preview
console
# Course: HTML & CSS
# The Daily Dribble Newsletter by Mark
# Code Reviewer: Shant Dashjian


## What You Did Well:

You met the objectives of this project:
1. You followed the design spec.
2. You met the specific requirements:
1. Color
2. Border
3. Image width
4. Link to a new tab


## Suggestions for Improvement:

1. Remove unneeded curly braces in CSS.
2. Remove dev comments in HTML.
3. Rather than using cryptic CSS class names numbered like `p-div1`, you could use more desritive ones like `main-section`, or better yet, semnatic HTML, like `main` and `footer`.
4. Use shorthand `padding: 10px 20px;` rather than `padding-top: 10px;` etc.


## Conclusion:

You did well meeting the objectives of this project. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.
Console
/index.html
-2:34