scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Truong's Unit Converter
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Truong's Unit Converter
AboutCommentsNotes
Code Review of Truong's Unit Converter
Expand for more info
code-review.md
run
preview
console
# Unit Converter by Truong
# Module: 3 - Making Websites Interactive
# Code Reviewer: Shant Dashjian


## What You Did Well:

You partially met the objectives of this project:
1. You partially followed the design spec. See Suggestion No. 1.
2. It converts the value between metric and imperial systems for length, volume, and mass.
3. You round the results to 3 decimal places using `.toFixed()`


## Suggestions for Improvement:

1. Pay closer attention to the design. Go back and review/redo Modules 2 and 3 if needed. Then redo this project. If you were hired and submitted this as a frontend developer, this code would be rejected for not meeting the design requirements.
2. Replace magic numbers with const.
3. Combine the event listeners into one. Attaching multiple event listeners to the same events to one element can lead to performance issues and unexpected behavior. Learn good patterns from the very beginning.


## Conclusion:

You did well meeting the JavaScript objectives of this project, practicing a good amount of JavaScript concepts. Moving forward, make sure to invest in following the given design spec to prevent a rejection of your code submission in the real world. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.


Console
/index.html
-12:22