scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Jainer's Basketball Scoreboard
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Jainer's Basketball Scoreboard
AboutCommentsNotes
Code Review of Jainer's Basketball Scoreboard
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Basketball Scoreboard by Jainer
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
1. You followed the design spec.
2. You have 6 functioning buttons, for adding 1, 2, and 3 points for each of the two teams: Home and Guest.
2. You implemented the stretch goal for starting a new game.
3. You added a nice personal design touch with the cool background.
4. You follow naming conventions for CSS and JS.
5. You show good code organization.


## Suggestions for Improvement:

1. Improve the design: Eliminate lower whitespace by making the height 100vh.
2. JS readability:
1. Clean up dev comments.
2. Use descriptive variable names rather than count1, count2.
3. DRY: Eliminate uneeded repetition in your JS code.


## Conclusion:

You did well meeting and exceeding the objectives of this project, practicing a good amount of JavaScript concepts. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.



Console
/index.html
-16:10