scrimba
Code Reviews
Code Review: Ashlyn's Solo Project - Digital Business Card
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review: Ashlyn's Solo Project - Digital Business Card
AboutCommentsNotes
Code Review: Ashlyn's Solo Project - Digital Business Card
Expand for more info
notes.md
run
preview
console
YAY!!
imported google font and font awesome!
used alt attribute for images!
used target="_blank" on external links!
great classNames

CSS:
- cursor hover effect
- hover effect - links

Suggestions:
- use rem for fonts and em for margin and padding:

em - units for the font-size property will be relative to the font-size of the parent element
- em units on other properties than font-size will be relative to the font-size of the current element.
- https://scrimba.com/learn/frontend/aside-the-em-unit-cofcf420c9bfc02e15c8d77e6
rem - units sizes will always be relative to the font-size of the root html element.
- https://scrimba.com/learn/frontend/aside-the-rem-unit-cd992yS9
Both of these are scalable units, which gives the ability to scale elements up and down, relative to a set value.

- remove border-radius on section bottom container before social media icons
- make alt more descriptive for screenreaders, etc. to better describe the image
- add hover effects to buttons and social media icons
- section font size is a little hard to read - make it a little larger?
- make responsive


Your question:
Can I import the components folder instead of importing each file separately

https://stackoverflow.com/questions/70807477/react-import-multiple-components-from-a-folder
https://medium.com/swlh/import-components-in-react-like-a-pro-b1340cb76a1b
Console
/index.html
-7:02