scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Harsha's Quizzical
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Harsha's Quizzical
AboutCommentsNotes
Code Review of Harsha's Quizzical
Expand for more info
code-review.md
run
preview
console
# Module: No. 11 - React Basics
# Project: Quizzical by Harsha
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
1. Two pages: start and questions
2. Get 5 questions from opentdb
3. Tally the answers
4. Style your app for good UX


## Suggestions for Improvement:

1. Decompose your UI. The idea of breaking down your React UI into components is fundamental to how you should build your React apps. You were supposed to practice it here. It's something you should do, not a nice thing to do. Each function in Quiz.js that returns a React Element is effectively a component. Extract them into their own files. Why? To make your code readable, maintainable, and reusable.
2. Catch errors in your fetch.
3. Be consistent when using hyphen-case to name your CSS classes. `magicpattern-one` should be `magic-pattern-one`.
4. Improve your design such that it looks godo without unusual behavior.


## Conclusion:

I hope you found my suggestions useful. Keep on coding.
Console
/index.html?
-9:45