scrimba
Bootcamp code reviews
πŸ‘©πŸΌβ€πŸ« Review of Solo Project: Choreslist (James Alderman)
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

πŸ‘©πŸΌβ€πŸ« Review of Solo Project: Choreslist (James Alderman)
AboutCommentsNotes
πŸ‘©πŸΌβ€πŸ« Review of Solo Project: Choreslist (James Alderman)
Expand for more info
readme.md
run
preview
console
# Code Review: ChoresList
### _Code by: James Alderman ,_
### _Reviewer: Felicity Evans_

## What you did well
- Met stretch goals
- Local storage
- Indentation
- Can't add repeat chore
- Design, considered transitions

## Questions / Concerns
One question - I'd love to see how to implement a feature that would use 'keyup' for the 'enter' btn - I tried to implement this coupled with research but wasn't successful!

choresInput.addEventListener('keypress', function (e) {
if (e.key === 'Enter') {
addChore()
}
});

## What could be improved?
- error msg delete (audio)
- clear placeholder area on click
- accessibility of button text -> (title)
- cursor: pointer


Console
/index.html
-5:23