Review of Solo Project Salesboard for Rachel

scrimba

Watch in fullscreen

by Felicity Evans

About

Comments

Notes

Review of Solo Project Salesboard for Rachel

by Felicity Evans

Expand for more info

README.md

run

preview

console

# Code Review: Salesboard
### _Code by: Rachel_
### _Reviewer: Felicity Evans_


## What you did well
- Made design your own
- Semantic html
- Flexbox
- Good use of const and let

## Questions
- Question related to another project (choreslist)?


## What could be improved
- Use buttons instead of links (semantic)
- Use function in js instead of inline onclick
- use join to remove "," in live achievements
- Live achievements 💰 should only be for every $1000
-

# Code Review: Salesboard

### _Code by: Rachel_

### _Reviewer: Felicity Evans_

## What you did well

- Made design your own

- Semantic html

- Flexbox

- Good use of const and let

## Questions

- Question related to another project (choreslist)?

## What could be improved

- Use buttons instead of links (semantic)

- Use function in js instead of inline onclick

- use join to remove "," in live achievements

- Live achievements 💰 should only be for every $1000

›

-7:33