scrimba
Code Reviews
Code Review: Urvish's Solo Project: Inspirational Quote Page
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review: Urvish's Solo Project: Inspirational Quote Page
AboutCommentsNotes
Code Review: Urvish's Solo Project: Inspirational Quote Page
Expand for more info
notes.md
run
preview
console
HTML - YAY!
great use of
- Google fonts!
- great formatting!

SUGGESTIONS:
- empty span?
- instead wrap div inside of anchor tag - this is okay
- only reference javascript once instead of twice

CSS - YAY!
- flex
- hover:

SUGGESTIONs:
- remove unnecessary empty space between lines of code
- remove span - not needed
- .quote-box (flex not needed...h1 and h2 are block elements)
display: flex;
flex-direction: column;
- .quote-box:hover (remove position - not needed)
/* For the link */
position: relative;
- remove span
- add style for a to remove line for hyperlink
- .author (remove fit-content and flex-end )
width: fit-content;
align-self: flex-end;
- instead use text-align: right
- remove .border-black (is it being used?)

Javascript
- create an index.js file and place all logic there
- you'll need to import the data from both of these files into the index.js file
- and you also need to export the data from these files
- reference index.js in html file (remember to use type="module")
Console
/index.html
-10:49