scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Gabby's Movie Watchlist
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Gabby's Movie Watchlist
AboutCommentsNotes
Code Review of Gabby's Movie Watchlist
Expand for more info
code-review.md
run
preview
console
# Module: No. 9 - Working with APIs
# Project: Movie Watchlist by Gabby
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
1. Two pages
2. Use search term to get results from the OMDB API
3. Add to Watchlist button, stores data in localStorage
4. Watchlist.html loads data from localStorage
5. Follow the design spec
2. You showed good code organization.
3. You included `doctype`, `title`, `viewport`, semantic HTML in your HTML.
4. You fowlloed CSS and JS naming conventions.


## Suggestions for Improvement:

1. Include better names for CSS. No numbers like container1 and container2.
2. Add `alt` to your `img` tags.
3. Maintain consistent file naming conventions.
4. Have more descriptive var names: `length` of what?
5. Maintain consistent variable naming conventions.
6. No need for global vars `storedDataArray`, `watchlistArray`, and `localStorageData`
7. Fix the recurring entry of movies in localStorage.


## Conclusion:

You met the objectives of this project. I hope you found my suggestions useful. Keep on coding.
Console
/index.html
-12:23