scrimba
Bootcamp code reviews
πŸ‘©πŸΌβ€πŸ« Review of Restaurant Ordering App (upak)
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

πŸ‘©πŸΌβ€πŸ« Review of Restaurant Ordering App (upak)
AboutCommentsNotes
πŸ‘©πŸΌβ€πŸ« Review of Restaurant Ordering App (upak)
Expand for more info
readme
run
preview
console
-- Design & functionality --

[] Google font
[] Space between ingredients
[] Responsive design
[] Add an overlay for your modal
[] Disable buttons after form submission

Tips:
- Look at figma file; if you isnpect the element you can see the font used.
Go to Google fonts and get the correct code to include in the css file
- Don't set a fixed with on the body tag in your CSS, use max-width instead
- Enclose your modal in another div to use as the overlay

-- HTML --

[] Don't call unnecessary style sheet e.g. font-awesome and normalize
[] Use google fonts
[] Confusing ids (main named "root" section named "main")
[] Dont use elements for styling pruposes alone (<div class="separator">)

-- CSS --

[] Imported google font incorrect
[] Don't declare unnecessary values e.g. "background-color: white;
[] Avoid pixel values
[] Reserve ids for Javascript, refer to CSS specificity rules: https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity

-- JavaScript --

* I learned to declare
let targetDataset = e.target.dataset;
let target = e.target;
for cleaner code
* I learned that forEach takes multiple parameters which includes index

[] Consistency with similar actions e.g. add class to modal to open and close it

Tips
- use toggle to add remove a class to modal



Console
/index.html
-9:04