scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Zlatko's Tindog
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Zlatko's Tindog
AboutCommentsNotes
Code Review of Zlatko's Tindog
Expand for more info
code-review.md
run
preview
console
# Project: Tindog by Zlatko
# Module: 7 - Next Level JS
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. Your app functions as expected and you met the requirements of this project:
1. Following the design specs
2. JS classes
3. modules (export/import)
2. You added a good message at the end of the workflow.
3. You used semantic HTML.
4. You code is well organized.
5. You follow naming conventions.

## Suggestions for Improvement:

1. DRY:
1. Extract an getCurrentDog method.
2. Remove repated code in HTML.
3. Combine CSS classes.
2. Readability: Fix indentation.
3. Defensiveness: Add fallback font.


## Conclusion:

I hope you found my suggestions useful. I wish you the best in your journey. Keep on coding.


Console
/index.html
-17:18