scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Wakasso's Color Scheme Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Wakasso's Color Scheme Generator
AboutCommentsNotes
Code Review of Wakasso's Color Scheme Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 9 - Working with APIs
# Project: Color Scheme Generator by Wakasso
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
1. Choose seed color with input of type=“color”
2. Choose color scheme mode with <select> box
3. Clicking button makes request to the Color API
4. Display the colors and thier hex values
2. You add your own style in the design, including the names of the colors.
3. You have good code orgnaization with whitespace and indentation.
4. You use semantic HTML.
5. In your HTML, you have a `doctype`, `title`, and also include the `viewport` meta tag.


## Suggestions for Improvement:

1. Follow hyphen-case naming convention for CSS and camelCase for JS.
2. Remove the `slice()` as it's not needed.
3. While I like your detailed comments for educational purposes as they explain what you're doing, you don't need this level of commenting for code submitted for production. You don't need to explain to yourself and other JavaScript developers how JavaScript works. Unneeded comments add clutter/noise. Keep your comments to 1. Explaining why you did something if it's not obvious 2. a piece of complicated code, like a regular expression. For everything else, let your code speak for itself, for example, name your functions in such a way that they become self-documenting. This is part of having a clean code.
4. Extra: If you want to challenge yourself further, consider trying to implemet the stretch goal of enabling the user to copy the hex code when they click on the color.


## Conclusion:

Your app works and you did well meeting the objectives. I hope you found my suggestions useful. Keep on coding.
Console
/index.html
"> box ">
-7:46