scrimba
Bootcamp code reviews
πŸ‘©πŸΌβ€πŸ« Review of Keith's Digital Business Card
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

πŸ‘©πŸΌβ€πŸ« Review of Keith's Digital Business Card
AboutCommentsNotes
πŸ‘©πŸΌβ€πŸ« Review of Keith's Digital Business Card
Expand for more info
readme.md
run
preview
console
# Code Review: React Business Card
### _Code by: Keith Petryshyn_
### _Reviewer: Felicity Evans_

## What you did well
- Good structure of components
- Clear CSS class names
- Importing images, shows understanding of how React works once bundled:
https://daveceddia.com/react-image-tag/#:~:text=You%20can%20put%20the%20image,just%20like%20with%20plain%20HTML.

## Questions
When splitting up a project like this, how would you do something like the background color and the container? I had to set the width and background color on every component because I couldnt figure out how to create a div container for the entire business card itself.

What is a good way to add those images into the button and center them with the text?

Any suggestions on how to handle the spacing between the different components? I used padding to try and get the backgrounds of each component to run into each other to make it look like one continuous background but it felt very clunky to do it that way.

Any other tips are welcome as this is my first time using React :)

## What could be improved
- Images, export at 2X
- Rely on the cascade to remove extra CSS
- add a span to button to centre icons and etx or use flex

## Challenge
- use same component for About and Interests and use props to populate
Console
/index.html
-8:29