scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Rohit's Password Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Rohit's Password Generator
AboutCommentsNotes
Code Review of Rohit's Password Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Password Generator by Rohit
# Code Reviewer: Shant Dashjian


## What You Did Well

1. You mostly meet all the core objectives of the project.
1. Follow the Figma design. You mostly did this. See suggestions.
2. Generate 2 random passwords.
3. Make each 15 characters long. You give the use the option to choose between 5-17.
2. You added the ability to copy each password.
3. You added the ability to include special characters.


## Suggestions for Improvement

1. Your modified design is not readable. I suggest you stick to the original design spec of the projects until you take the UI design module.
2. Your code lacks good indentation. Format your code for better readability and maintainability.
3. Use white space for better code organization and readability.
4. Simplify the `check()` function.
5. Clean up the `value` and `length` redundency. You just need one.


## Conclusion

I think you did well meeting the objectives and implementing additional features. I wish you all the best in your journey and I hope you found my suggestions useful. Keep on coding.

Console
/index.html
-10:21