Code Review of Fathiya's Unit Converter

scrimba

Watch in fullscreen

by Shant Dashjian

About

Comments

Notes

Code Review of Fathiya's Unit Converter

by Shant Dashjian

Expand for more info

code-review.md

run

preview

console

# Module: No. 3 - Making Websites Interactive
# Project: Unit Converter by Fathiya (PhoeniX)
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
    1. Follow the design spec.
    2. Convert to both systems for length, volume, and mass.
    3. Round to 3 decimal places.
2. You implemented a light/dark theme conversion button, using CSS vars in combination with CSS classes, along with the necessary JavaScript event listener and `window.matchMedia` query.
3. You used the `:hover` pseudoclass for the button.
4. You prevented non-numeric input from getting converted.
5. In your HTML, you used `doctype`, `title`, and `viewport` meta tag.
6. Your code is well organized.


## Suggestions for Improvement:

1. Add some padding around the theme icon for better UI design. This is subjective.
2. Remove magic numbers.
3. Deal with negative input values.
4. Make your theme-related code DRYer.
5. Make your conversion code DRYer.


## Conclusion:

You did well meeting the objectives of this project and going above and beyond. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.

# Module: No. 3 - Making Websites Interactive

# Project: Unit Converter by Fathiya (PhoeniX)

# Code Reviewer: Shant Dashjian

## What You Did Well:

1. You met the objectives of this project:

1. Follow the design spec.

2. Convert to both systems for length, volume, and mass.

3. Round to 3 decimal places.

2. You implemented a light/dark theme conversion button, using CSS vars in combination with CSS

classes, along with the necessary JavaScript event listener and `window.matchMedia` query.

3. You used the `:hover` pseudoclass for the button.

4. You prevented non-numeric input from getting converted.

5. In your HTML, you used `doctype`, `title`, and `viewport` meta tag.

6. Your code is well organized.

## Suggestions for Improvement:

1. Add some padding around the theme icon for better UI design. This is subjective.

2. Remove magic numbers.

3. Deal with negative input values.

4. Make your theme-related code DRYer.

5. Make your conversion code DRYer.

## Conclusion:

You did well meeting the objectives of this project and going above and beyond. I hope you found my

-20:23