Code Review of Yaseen's Unit converter

scrimba

Watch in fullscreen

by Shant Dashjian

About

Comments

Notes

Code Review of Yaseen's Unit converter

by Shant Dashjian

Expand for more info

code-review.md

run

preview

console

# Unit Converter by Yaseen
# Module: 3 - Making Websites Interactive
# Code Reviewer: Shant Dashjian


## What You Did Well:
1. You met the objectives of this solo project:
    1. You followed the Figma design
    2. You convert between systems as length, volume, and mass
    3. You fix the numbers to 3 decimal places
2. Your HTML, CSS, and JavaScript have:
    1. Good code formatting
    2. Good naming conventions
    3. Good organization


## Suggestions for Improvement:
1. Refactor:
    1. Remove magic numbers
    2. Keep your code DRY
2. Deal with edge cases of the input values: negative numbers, non-numbers


## Conclusion:
You did well on meeting the objectives of this solo project. I hope you found my suggestions useful. I wish you the best with your journey. Keep on coding.

# Unit Converter by Yaseen

# Module: 3 - Making Websites Interactive

# Code Reviewer: Shant Dashjian

## What You Did Well:

1. You met the objectives of this solo project:

1. You followed the Figma design

2. You convert between systems as length, volume, and mass

3. You fix the numbers to 3 decimal places

2. Your HTML, CSS, and JavaScript have:

1. Good code formatting

2. Good naming conventions

3. Good organization

## Suggestions for Improvement:

1. Refactor:

1. Remove magic numbers

2. Keep your code DRY

2. Deal with edge cases of the input values: negative numbers, non-numbers

## Conclusion:

You did well on meeting the objectives of this solo project. I hope you found my suggestions

useful. I wish you the best with your journey. Keep on coding.

-10:12