scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Fredrik's Color Scheme Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Fredrik's Color Scheme Generator
AboutCommentsNotes
Code Review of Fredrik's Color Scheme Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 9 - Working with APIs
# Project: Color Scheme Generator by Fredrik
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
1. Choose seed color with input of type=“color”.
2. Choose color scheme mode with <select> box.
3. Clicking button makes request to the Color API.
4. Display the colors and their hex values.
2. You added a dark/light theme toggler.
3. You implemented the copy color hex code feature.
4. Your JavaScript code is very well-organized for reusability and separation of concerns.
5. You made your design responsive.
6. You followed CSS and JS naming conventions.


## Suggestions for Improvement:

1. Set the default hex color in `renderDefaultColorSchema` to reflect the schema generated when you first load the app.
2. You code is already self-documenting and that's very good. Now remove all unneeded comments. They just add clutter.
3. For your responsive design, best practice is to go **mobile-first**. This means style your app for mobile, and use media queries to deal with wider screens, not the other way around.


## Conclusion:

Excellent job working on this project. You show good coding practices and a knack for separation of concerns and reusability. I hope you found my suggestions useful. Keep on coding.
Console
/index.html
"> box ">
-10:30