Code Review of Cory's Color Scheme Generator

scrimba

Watch in fullscreen

by Shant Dashjian

About

Comments

Notes

Code Review of Cory's Color Scheme Generator

by Shant Dashjian

Expand for more info

code-review.md

run

preview

console

# Module: No. 9 - Working with APIs
# Project: Color Scheme Generator by Cory
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
    1. Choose seed color with input of type=“color”.
    2. Choose color scheme mode with <select> box.
    3. Clicking button makes request to the Color API.
    4. Display the colors and their hex values.
2. You implemented the copy feature using `navigator.clipboard.writeText()` function. I expecially liked the scaling of the color box when `:hover`ing over it.
3. Your code is well-organized.

## Suggestions for Improvement:

1. Have the app fetch initial values rather than an empty page.
2. Deal with fetch errors by adding `.catch` to your `fetch` to handle rejected promises.


## Conclusion:

This is a good implementation of the color schema generator. Well done. I hope you found my suggestions useful. Keep on coding.

# Module: No. 9 - Working with APIs

# Project: Color Scheme Generator by Cory

# Code Reviewer: Shant Dashjian

## What You Did Well:

1. You met the requirements of this project:

1. Choose seed color with input of type=“color”.

2. Choose color scheme mode with <select> box.

3. Clicking button makes request to the Color API.

4. Display the colors and their hex values.

2. You implemented the copy feature using `navigator.clipboard.writeText()` function. I expecially

liked the scaling of the color box when `:hover`ing over it.

3. Your code is well-organized.

## Suggestions for Improvement:

1. Have the app fetch initial values rather than an empty page.

2. Deal with fetch errors by adding `.catch` to your `fetch` to handle rejected promises.

## Conclusion:

This is a good implementation of the color schema generator. Well done. I hope you found my

-4:31