scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Polina Fidelis' Basketball scoreboard
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Polina Fidelis' Basketball scoreboard
AboutCommentsNotes
Code Review of Polina Fidelis' Basketball scoreboard
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Basketball Scoreboard by Polina Fidelis
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
1. You followed the design spec.
2. You have 6 functioning buttons, for adding 1, 2, and 3 points for each of the two teams: Home and Guest.
2. You implemented the stretch goal of resetting the scores.
3. You following naming convnetions for CSS and JS.
4. In your HTMl, you used `doctype`, `title`, and `viewport` tag.


## Suggestions for Improvement:

1. Design: Decrease the padding in scores for better UI design.
2. Clean code:
1. Remove duplicate and buggy font link in HTML.
2. Remove duplication in functions in the JS.


## Conclusion:

You did well meeting the objectives of this project, practicing a good amount of JavaScript concepts. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.



Console
!
Error: Failed to load https://fonts.cdnfonts.com/css/%20cursed-timer-ulil
,
/index.html
-9:45