scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Digbijaya's Password Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Digbijaya's Password Generator
AboutCommentsNotes
Code Review of Digbijaya's Password Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Password Generator by Digbijaya
# Code Reviewer: Shant Dashjian


## What You Did Well

1. Well done! You meet all the core objectives of the project.
1. Generate 2 random passwords.
2. You used your own cool design.
3. You let the user change the length of the password,
using a cool slider which is a styled `input` of `type="range"`.
4. You implemented the copy feature.


## Suggestions for Improvement

1. Remove dev commented out console.logs.
2. `document.execCommand()` is deprecated. See instead `https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText`.
3. Add whitespace in the design as needed.


## Conclusion

I think you did well meeting and exceeding the objectives. I wish you all the best in your journey and I hope you found my suggestions useful. Keep on coding.

Console
/index.html
-3:54