👩🏼‍🏫 Review of Solo Project: Send to Pager (Joseph Goodwin)

scrimba

Watch in fullscreen

by Felicity Evans

About

Comments

Notes

👩🏼‍🏫 Review of Solo Project: Send to Pager (Joseph Goodwin)

by Felicity Evans

Expand for more info

readme.md

run

preview

console

# Code Review: Send to Pager
### _Code by: Joseph Goodwin ,_
### _Reviewer: Felicity Evans_

## What you did well
- followed design
- clean commented code
- edge case: error message if character > 10


## What could be improved?
- change fixed pixel heights and widths in css
- consider using grid for phone buttons
still able to send if char > 10, consider diabling button
    - sendBtnEle.disabled = "disabled"
- cursor for hover
- avoid using ids for styling to minimise problems with specificity

# Code Review: Send to Pager

### _Code by: Joseph Goodwin ,_

### _Reviewer: Felicity Evans_

## What you did well

- followed design

- clean commented code

- edge case: error message if character > 10

## What could be improved?

- change fixed pixel heights and widths in css

- consider using grid for phone buttons

still able to send if char > 10, consider diabling button

- sendBtnEle.disabled = "disabled"

- cursor for hover

- avoid using ids for styling to minimise problems with specificity

-5:21