scrimba
Bootcamp code reviews
πŸ‘©πŸΌβ€πŸ« Review of Tam HikeFinder Solo Project
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

πŸ‘©πŸΌβ€πŸ« Review of Tam HikeFinder Solo Project
AboutCommentsNotes
πŸ‘©πŸΌβ€πŸ« Review of Tam HikeFinder Solo Project
Expand for more info
readme.md
run
preview
console
# Code Review: HikeFinder website
### _Code by: Tam_
### _Reviewer: Felicity Evans_

## What you did well
- Grid areas
- Media queries
- Multiple designs


## Questions
- I can't seem to be able to make the background image overlay work like in the figma file https://www.figma.com/file/gWb9LGqmoEHWjsLFKrjDWs/Solo-Project%3A-HikeFinder?node-id=0%3A1&t=FDCcshj1UMikMkOg-0. Do you have any advice how to tackle that?

- For the images in the Explore page, it was hard making them align with each other. Is there a way to do that?

## What could be improved
- Indentation (Ctrl + K Ctrl + F)
- Use alt text
- Put reset first in order of stylesheets
- use of normalise twice
- importing all of font-awesome, may be better to use selected icons
- Background image: create another container "hero-container"
- .trail-img {width: 144px}
- .trail-card - is max width needed? (wrap all elements in container instead)
- reduce @media query size for laptop (987px)
Console
/explore.html
-9:10