scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of GENEXIS's Unit Converter
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of GENEXIS's Unit Converter
AboutCommentsNotes
Code Review of GENEXIS's Unit Converter
Expand for more info
code-review.md
run
preview
console
# Unit Converter by GENEXIS
# Module: 3 - Making Websites Interactive
# Code Reviewer: Shant Dashjian


## What You Did Well:

You met the objectives of this project:
1. Your app works and converts to both systems for length, volume, and mass.
2. You round to 3 decimal places.
3. Extra: You added a useful message as placeholder for the text prior to te user entering any input.
4. You generally followed the design with color, font, and design. You have deviated a bit with the rounded borders and narrower boxes.


## Suggestions for Improvement:
1. If the design deviation was intentional to add your personal touch in a student solo project, great. But make sure to keep the intention. I think the intention for the text in each of the conversion boxes was for it to be in one line. You have it split into two lines, which impacts the UX.
2. Remove magic numbers for better readability.
3. Deal with the edge cases for the input: non-numeric input, negative input.


## Conclusion:

You did well meeting the objectives of this project. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.
Console
/index.html
-7:57