scrimba
Bootcamp code reviews
πŸ‘©πŸΌβ€πŸ« Review of Solo Project: Learning Journal (Ajo)
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

πŸ‘©πŸΌβ€πŸ« Review of Solo Project: Learning Journal (Ajo)
AboutCommentsNotes
πŸ‘©πŸΌβ€πŸ« Review of Solo Project: Learning Journal (Ajo)
Expand for more info
readme.md
run
preview
console
# Code Review: Learning Journal
### _Code by: Ajo ,_
### _Reviewer: Felicity Evans_

## What you did well
- Concern for code structure, naming conventions
- Responsive design (mobile first)
- Well commented CSS
- Use of grid-template-area

## Questions / Concerns
1) I'm trying to figure out what's "best practice" when it comes to setting margins, e.g. margins on single elements vs. on larger sections, on headings vs. paragraphs etc. Are there any standards/guidelines to follow? Am I on the right track?
2) I made three separate html files and one single css file. Maybe a bit confusing?

## What could be improved?
- Names of html files (index is default page)
- Include Nav element
- Class names need not be unique: blog-two, blog-three or unique to page e.g. index-1
- Instead think about functionality / Component-based
- Convention to use grid for main areas of page but flexbox for subsections


## Challenge
- Alter CSS to use flexbox

Console
/index-3.html
-13:17