scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Kassandra's Color Scheme Generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Kassandra's Color Scheme Generator
AboutCommentsNotes
Code Review of Kassandra's Color Scheme Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 9 - Working with APIs
# Project: Color Scheme Generator by Kassandra
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the requirements of this project:
1. Choose seed color with input of type=“color”
2. Choose color scheme mode with <select> box
3. Clicking button makes request to the Color API
4. Display the colors and thier hex values
2. You implemented the stretch goal of copying the color hex code to the clipboard.
The error you see in Scrimba on Chrome is specific to that IDE + browser combination. It works fine in production.
3. You code is well organized.
4. You follow CSS and JS naming conventions.
5. You studyied the API docs and used what you learned in your app, specifically in regards to the `count` query parameter.


## Suggestions for Improvement:

1. Remove unneeded hard-coded colors in HTML.
2. Remove unneeded hexArray global variable.
3. Remove unneeded comments.
4. Keep with the API intended outcome in regards to the color scheme count and colors coming back, unless there is a good reason not to.


## Conclusion:

Excellent job! You met and exceeded the expectations of this project. I hope you find my suggestions useful. Keep on coding.
Console
/index.html
"> box ">
-13:12