scrimba
Michael Larocca's Scrimba Code Reviews
Shane Pinder: Solo Project - Learning Journal
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Shane Pinder: Solo Project - Learning Journal
AboutCommentsNotes
Shane Pinder: Solo Project - Learning Journal
Expand for more info
Code Review
run
preview
console
Code Review
I am Michael Larocca, a Scrimba code reviewer
Today I am reviewing your Learning Journal solo project

First Impression
Great job! Your code works as expected, and your styles look great.

Issues Brought to Attention
1. Is it better to use pixels or em for the gap property in Flexbox and Grid?
2. For media queries, is it better to use pixels or em as the units for min-width and max-width?

Gap property
When using the gap property in Flexbox or Grid, you can choose between pixels or em to define the gap size between items. If you want a fixed gap size that won't change with font size or screen resolution, use pixels. But if you want the gap to scale with the font size, use em.

Media queries: pixels or em?
For min-width and max-width, it's better to use em as the units to make them responsive to changes in font size. However, using pixels is also okay, especially for fixed-width layouts.

Suggestions: use min-width ( not just for media queries )
Min-width is a property in CSS that sets the minimum width of an element. It is important because it allows you to control how your website or application looks on different screen sizes. For example, you can set a min-width for a container element to ensure that it doesn't get too small on smaller screens, which can lead to content overlapping or becoming unreadable. By setting a min-width, you can ensure that your website or application remains readable and usable on all screen sizes.
Console
/index.html
-6:12