scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of John's Basketball Scoreboard
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of John's Basketball Scoreboard
AboutCommentsNotes
Code Review of John's Basketball Scoreboard
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Basketball Scoreboard by John
# Code Reviewer: Shant Dashjian


## What You Did Well:

1. You met the objectives of this project:
1. You followed the design spec.
2. You have 6 functioning buttons, for adding 1, 2, and 3 points for each of the two teams: Home and Guest.
2. You added the ability to reset the score.
3. You picked Orbitron, a different yet cool font, for the digits and reset button.
4. You followed naming conventions for CSS and JS.
5. Your code is well-organized.


## Suggestions for Improvement:

1. Remove unneeded repetition in your score-adding functionality.
2. In your CSS file, think of good comments to group your selectors.
3. Challenge from the future: Rather than adding an event listener to the score-adding buttons one by one, how could you make happen in less lines of code?


## Conclusion:

You did well meeting and exceeding the objectives of this project, practicing a good amount of JavaScript concepts. I hope you found my suggestions useful and I wish you the best in your journey. Keep on coding.



Console
/index.html
-11:47