👩🏼‍🏫 Review of Solo Project - Learning Journal

scrimba

Watch in fullscreen

👩🏼‍🏫 Review of Solo Project - Learning Journal - Cahn

by Felicity Evans

About

Comments

Notes

👩🏼‍🏫 Review of Solo Project - Learning Journal - Cahn

by Felicity Evans

Expand for more info

readme.md

run

preview

console

# Code Review: Learning Journal
### _Code by: Cahn Gulliver_
### _Reviewer: Felicity Evans_


## What you did well
- used JS to render blog content
- responsive, good break points
- Use of grid template ares
- Clear class names

## Questions
Hey!
had a lot of fun with this one and playing around with CSS Grid!
Only a few issues, The height of all the blog images are not even, is there any way to do this while maintaining the layout and aspect ratio of each image?

Also, the home link doesn't work when the website is deployed to Netlify but does in the Scrimba mini browser so I'm not sure what the issue is there 

## What could be improved
- link: "/home", should be "/index.html" or "/"
- missing blog page
- images: 
    aspect-ratio: 3 / 2;
    object-fit: cover;
- alt tag for content images

# Code Review: Learning Journal

### _Code by: Cahn Gulliver_

### _Reviewer: Felicity Evans_

## What you did well

- used JS to render blog content

- responsive, good break points

- Use of grid template ares

- Clear class names

## Questions

Hey!

had a lot of fun with this one and playing around with CSS Grid!

Only a few issues, The height of all the blog images are not even, is there any way to do this

while maintaining the layout and aspect ratio of each image?

Also, the home link doesn't work when the website is deployed to Netlify but does in the Scrimba

mini browser so I'm not sure what the issue is there

## What could be improved

- link: "/home", should be "/index.html" or "/"

- missing blog page

- images:

aspect-ratio: 3 / 2;

object-fit: cover;

- alt tag for content images

-5:32