scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Kamil's password-generator
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Kamil's password-generator
AboutCommentsNotes
Code Review of Kamil's password-generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Password Generator by Kamil
# Code Reviewer: Shant Dashjian


## What You Did Well

1. Well done! You meet all the core objectives of the project.
1. Follow the Figma design.
2. Generate 2 random passwords.
3. Make each 15 characters long.
2. You added your personal touch to the design.
3. You added the ability to change password length.
4. You added the ability to include/exclude numbers and special characters.
5. Your code is generally well organized.


## Suggestions for Improvement

1. Remove console.logs.
2. Remove extra whitespace and add whitespace as needed in CSS code.
3. Improve password text contrast to be at least 4.5:1.
4. Remove unneeded comments. Let your code be self-documenting.


## Conclusion

I think you did well meeting and exceeding the expectations. I wish you all the best in your journey and I hope you found my suggestions useful. Keep on coding.

Console
"ANtBEDKaRcxEXCA"
,
"MDmhbyCQEylKxWH"
,
"OMaFmwAHQVMnWkd"
,
"MbrAYGrtAnDeZzr"
,
""
,
""
,
"kENoituMgVUuEylWHoPklsVkFuYHNEmpaFKoVGNNbnPzKHmsTxsHCbNqKlnoVEJqhLLbSRzsVVNyMqocVFtOzcZsvGIUroPEpSqm"
,
"YFdpqAZlgcuXpgrbLJKdRIVzSZQroybQkoiJmlEYRpxMuUEGyNMZelmnKmOCcPFfzTyCRRktSjzmmKLeiATmaPDuuNYKELbVjZmR"
,
"YARxHjzvNO"
,
"FSfUSiEwxb"
,
"ZbKKub36C3"
,
"c6PHdOP04l"
,
"9.NlX?7Ob&"
,
"(c-I%]r%70"
,
"jOU1pn|c6%"
,
"jC51Jj`hQu"
,
"u`A+Va==?6"
,
"y=k>-7[ClW"
,
"FLJLTHkDKQ"
,
"JxHFGymNYa"
,
"0lDmuP108m"
,
"NryoeHqs7I"
,
"UCwVIOaZYC"
,
"jqxQCtXKAN"
,
"pVHCxAYFDv"
,
"jGeeItNKMV"
,
/index.html
-5:54