scrimba
Shant Dashjian's 96 Code Reviews of the Scrimba Frontend Career Path Students Projects
Code Review of Muskan's Password-Generator
github repo
Go Pro!Bootcamp

Bootcamp

Study group

Collaborate with peers in your dedicated #study-group channel.

Code reviews

Submit projects for review using the /review command in your #code-reviews channel

Code Review of Muskan's Password-Generator
AboutCommentsNotes
Code Review of Muskan's Password-Generator
Expand for more info
code-review.md
run
preview
console
# Module: No. 3 - Making Websites Interactive
# Project: Password Generator by Muskan
# Code Reviewer: Shant Dashjian


## What You Did Well

1. Well done! You met all the core objectives of the project and added new features.
1. Follow the Figma design. You used the initial design and added features keeping the original design.
2. Generate 2 random passwords.
3. Make each 15 characters long. You provide a slider for password length from 0 to 100.
2. You provided filters for letters, numbers, and special characters.
3. You added the copy feature.
4. You JS is well-organized and you followed naming conventions.


## Suggestions for Improvement

1. Remove left behind console.logs.
2. Rather than the default password max length of 100, choose a max length that would keep your passwords within their containers.
3. Initially your password includes letters, numbers, and special characters. Have the checkboxes initially checked to reflect that.
4. Improve the contrast of the text "password copied!" so it's visible.
5. In your CSS, make sure you provide values for your CSS variables.


## Conclusion

I think you did well meeting and exceeding the objectives. I wish you all the best in your journey and I hope you found my suggestions useful. Keep on coding.

Console
91
,
/index.html
-10:58